Skip to content

refs #1210 Forward result of NorthService::sendToDispatcher() to the …#1211

Merged
MarkRiddoch merged 5 commits intofledge-iot:developfrom
FlorentP42:1210-return-value-of-operations-not-forwarded-propelry-to-north-plugins
Jan 9, 2024
Merged

refs #1210 Forward result of NorthService::sendToDispatcher() to the …#1211
MarkRiddoch merged 5 commits intofledge-iot:developfrom
FlorentP42:1210-return-value-of-operations-not-forwarded-propelry-to-north-plugins

Conversation

@FlorentP42
Copy link
Copy Markdown
Contributor

…output of NorthService::operation().

Closes #1210

…() to the output of NorthService::operation().

Signed-off-by: Florent Peyrusse <florent.peyrusse@external.equans.com>
@FlorentP42 FlorentP42 force-pushed the 1210-return-value-of-operations-not-forwarded-propelry-to-north-plugins branch from 71444ed to ae9f3ab Compare October 24, 2023 14:39
@FlorentP42
Copy link
Copy Markdown
Contributor Author

@MarkRiddoch: Please let me know when this can be reviewed.
PS: Any idea why unit test pipelines are not running on this PR?

@MarkRiddoch
Copy link
Copy Markdown
Contributor

Sorry, for some reason I did not get a notification that this was waiting. I've just checked and the unit tests seem to be running now, I did an "Update Branch" to force a rerun of the tests.

@FlorentP42
Copy link
Copy Markdown
Contributor Author

FlorentP42 commented Dec 1, 2023

Can you see any unit test result then? For me it looks like this:
image

It does not appear like they are even trying to run...

If you wtill want to merge like this it's fine by me... But I would like to have confirmation through the unit tests that this change did not have any unplanned impacts somewhere else that the unit tests could reveal.

PS: If you didn't get any notification for the current PR, you might want to have a look at #1208 which is in the same state.

@FlorentP42
Copy link
Copy Markdown
Contributor Author

Oh, now it seems to be passed, all right then...
image

@MarkRiddoch MarkRiddoch merged commit 15da02e into fledge-iot:develop Jan 9, 2024
@FlorentP42 FlorentP42 deleted the 1210-return-value-of-operations-not-forwarded-propelry-to-north-plugins branch January 19, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Return value of operations not forwarded propelry to north plugins

2 participants